Macdonell became famous with the publication of England, Their England. The book gained considerable critical and popular acclaim, and won the James Tait Black Award. It is regarded as one of the classics of English humour and is much-loved by readers for its evocation of England between the wars.